|Summary:||LLINT loadisFromInstruction doesn't need special case for big endians|
|Product:||WebKit||Reporter:||Tomas Popela <tpopela>|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
|Bug Blocks:||128743, 132333|
Description Tomas Popela 2014-04-29 04:30:02 PDT
The change introduced in r167076 was wrong. We cannot apply the offset adjustment on every loadisFromInstruction usage as the instruction (UnlinkedInstruction) is declared as an union (i.e. with the int32_t operand variable). The offset of the union members will be the same as the offset of the first one, that is 0. The behavior here is the same on little and big endian architectures us we don't need special case for big endians.
Comment 2 Mark Lam 2014-04-29 06:10:08 PDT
Comment 3 Tomas Popela 2014-04-29 06:28:43 PDT
Created attachment 230373 [details] Proposed patch v2 Fixes after Mark's review
Comment 4 Mark Lam 2014-04-29 06:29:53 PDT
Comment on attachment 230373 [details] Proposed patch v2 r=me
Comment 5 WebKit Commit Bot 2014-04-29 07:06:37 PDT
Comment on attachment 230373 [details] Proposed patch v2 Clearing flags on attachment: 230373 Committed r167929: <http://trac.webkit.org/changeset/167929>
Comment 6 WebKit Commit Bot 2014-04-29 07:06:40 PDT
All reviewed patches have been landed. Closing bug.