Summary: | LLINT loadisFromInstruction doesn't need special case for big endians | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, mark.lam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 128743, 132333 | ||||||||
Attachments: |
|
Description
Tomas Popela
2014-04-29 04:30:02 PDT
Created attachment 230365 [details]
Proposed patch
Comment on attachment 230365 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=230365&action=review Thanks for fixing this. If you update the ChangeLog comment, we should be good to go. > Source/JavaScriptCore/ChangeLog:9 > + The change introduced in r167076 was wrong. We cannot apply the offset > + adjustment on every loadisFromInstruction usage as the instruction Please change “cannot” to “should not” and remove “every”. As it read previously, it implied that there are some cases where the offset should be applied, which is not true. It is always wrong to applied that offset. > Source/JavaScriptCore/ChangeLog:11 > + operand variable). The offset of the union members will be the Please change “union” to “other union”. > Source/JavaScriptCore/ChangeLog:13 > + same on little and big endian architectures thus we don't need Missing period between “architectures. Thus”. Created attachment 230373 [details]
Proposed patch v2
Fixes after Mark's review
Comment on attachment 230373 [details]
Proposed patch v2
r=me
Comment on attachment 230373 [details] Proposed patch v2 Clearing flags on attachment: 230373 Committed r167929: <http://trac.webkit.org/changeset/167929> All reviewed patches have been landed. Closing bug. |