| Summary: | Scrollbars do not update properly when topContentInset changes dynamically | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
| Component: | Layout and Rendering | Assignee: | Beth Dakin <bdakin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, bdakin, rniwa, sam, simon.fraser, thorton | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Beth Dakin
2014-04-28 16:03:00 PDT
Created attachment 230331 [details]
Patch
Comment on attachment 230331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230331&action=review > Source/WebCore/page/FrameView.cpp:962 > + // To fully update scrollbars, we need to call both updateScrolbars() and frameViewDidChangeSize() which will > + // will update all of the scrolling-related layers. I don't think the comment is necessary. > Source/WebCore/page/FrameView.cpp:964 > + if (RenderView* renderView = this->renderView()) { We already have a local and already early returned for RenderView. Thank you! http://trac.webkit.org/changeset/167911 Looks like this regressed PLT by ~2% (In reply to comment #4) > Looks like this regressed PLT by ~2% This seems very unlikely… (In reply to comment #5) > (In reply to comment #4) > > Looks like this regressed PLT by ~2% > > This seems very unlikely… Yeah, looks like it was a temporary fluke. The numbers look better now. |