| Summary: | Build failure in RenderFlowThread.cpp when building release with ASSERT_WITH_SECURITY_IMPLICATION | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Drew Yao <ayao> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abucur, ddkilzer, dfarler |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
This patch was rolled out for a separate reason by Bug 132290, so duping to that. *** This bug has been marked as a duplicate of bug 132290 *** |
When building a release build of WebKit with ASSERT_WITH_SECURITY_IMPLICATION enabled, I'm getting a build error /Volumes/data_apps/WebKit/Source/WebCore/rendering/RenderFlowThread.cpp:606:38: error: use of undeclared identifier 'checkLinesConsistency' ASSERT_WITH_SECURITY_IMPLICATION(checkLinesConsistency(blockFlow)); http://trac.webkit.org/changeset/167871 added the assert. In RenderFlowThread.cpp, RenderFlowThread::checkLinesConsistency and other functions are defined inside a #ifndef NDEBUG. Instead, it should be #if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED By default, the behavior will be the same, but this will fix the build for release + ASSERT_WITH_SECURITY_IMPLICATION. See http://trac.webkit.org/changeset/160462 for an example of a similar change.