Bug 132248

Summary:

[GTK] Some media fragment tests are flaky

Product:

WebKit

Reporter:

Xabier Rodríguez Calvar <calvaris>

Component:

WebCore Misc.

Assignee:

Charlie Turner <cturner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, chavarria1991, clopez, commit-queue, cturner, eric.carlson, magomez, webkit-bug-importer

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187522

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Xabier Rodríguez Calvar

Reported 2014-04-28 03:23:50 PDT

media/media-fragments/TC0078.html [ Failure Pass ] media/media-fragments/TC0086.html [ Failure Pass ]

Attachments
Patch (23.20 KB, patch) 2019-07-08 10:19 PDT, Charlie Turner	no flags	Details Formatted Diff Diff
Patch for landing (34.71 KB, patch) 2019-07-08 13:04 PDT, Charlie Turner	no flags	Details Formatted Diff Diff
Patch for landing (23.20 KB, patch) 2019-07-08 13:07 PDT, Charlie Turner	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Xabier Rodríguez Calvar

Comment 1 2014-04-28 04:23:53 PDT

Added media/media-fragments/TC0037.html [ Failure Pass ] media/media-fragments/TC0085.html [ Failure Pass ] media/media-fragments/TC0091.html [ Failure Pass ]

Carlos Alberto Lopez Perez

Comment 2 2014-07-16 10:19:55 PDT

I'm adding this on the test expectation for this bug: media/media-fragments/TC0001.html [ Timeout Pass ] media/media-fragments/TC0002.html [ Crash ] media/media-fragments/TC0014.html [ Failure Pass ] media/media-fragments/TC0015.html [ Crash ] media/media-fragments/TC0015.html [ Failure Pass ] media/media-fragments/TC0038.html [ Crash ] media/media-fragments/TC0085.html [ Crash ] media/media-fragments/TC0086.html [ Failure Timeout Pass ] media/media-fragments/TC0087.html [ Timeout Pass ] media/media-fragments/TC0088.html [ Crash ] media/media-fragments/TC0090.html [ Failure Pass ]

Carlos Alberto Lopez Perez

Comment 3 2014-07-16 10:20:58 PDT

Sorry: for the [ Crash ] ones, it really is [ Crash Pass ] (only crashes sometimes)

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 4 2015-04-17 04:01:53 PDT

Adding the following test which timeout sometimes: media/media-fragments/TC0055.html [ Failure Pass Timeout ] media/media-fragments/TC0058.html [ Timeout Pass ]

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 5 2015-04-21 02:40:24 PDT

Added: media/media-fragments/TC0063.html [ Timeout Pass ]

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 6 2015-04-21 04:03:37 PDT

media/media-fragments/TC0061.html [ Timeout Pass ] media/media-fragments/TC0067.html [ Timeout Pass ] media/media-fragments/TC0080.html [ Timeout Pass ]

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 7 2015-05-15 03:39:08 PDT

*** Bug 143709 has been marked as a duplicate of this bug. ***

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 8 2015-05-19 03:08:03 PDT

media/media-fragments/TC0065.html [ Timeout Pass ] media/media-fragments/TC0066.html [ Timeout Pass ] media/media-fragments/TC0068.html [ Timeout Pass ] media/media-fragments/TC0081.html [ Timeout Pass ] Updating test expectations on bug #145166.

Miguel Gomez

Comment 9 2018-09-06 07:33:07 PDT

media/media-fragments/TC0004.html [ Timeout Crash Pass ] media/media-fragments/TC0017.html [ Timeout Pass ]

Charlie Turner

Comment 10 2019-07-08 10:19:49 PDT

Created attachment 373640 [details] Patch

Charlie Turner

Comment 11 2019-07-08 10:22:38 PDT

CC Eric, do you think this stop time is OK? On Mac/iOS, looks like Apple is seeing a stddev > 0.5 as well, see https://bugs.webkit.org/show_bug.cgi?id=187522#c4

Eric Carlson

Comment 12 2019-07-08 10:40:20 PDT

(In reply to Charlie Turner from comment #11) > CC Eric, do you think this stop time is OK? On Mac/iOS, looks like Apple is > seeing a stddev > 0.5 as well, see > https://bugs.webkit.org/show_bug.cgi?id=187522#c4 @ cturner - this seems fine, thanks for the fix!

Charlie Turner

Comment 13 2019-07-08 13:04:39 PDT

Created attachment 373659 [details] Patch for landing

Charlie Turner

Comment 14 2019-07-08 13:05:00 PDT

Ta Eric!

WebKit Commit Bot

Comment 15 2019-07-08 13:05:40 PDT

Comment on attachment 373659 [details] Patch for landing Rejecting attachment 373659 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 373659, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=373659&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=132248&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 373659 from bug 132248. Fetching: https://bugs.webkit.org/attachment.cgi?id=373659 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 38 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp Hunk #1 FAILED at 156. Hunk #2 FAILED at 261. Hunk #3 FAILED at 363. Hunk #4 succeeded at 510 with fuzz 2 (offset 7 lines). Hunk #5 FAILED at 604. Hunk #6 FAILED at 616. Hunk #7 FAILED at 634. 6 out of 7 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/gstreamer/jhbuild.modules Hunk #1 FAILED at 92. 1 out of 1 hunk FAILED -- saving rejects to file Tools/gstreamer/jhbuild.modules.rej patching file Tools/gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/media-fragments/TC0004-expected.txt patching file LayoutTests/media/media-fragments/TC0005-expected.txt patching file LayoutTests/media/media-fragments/TC0006-expected.txt patching file LayoutTests/media/media-fragments/TC0011-expected.txt patching file LayoutTests/media/media-fragments/TC0015-expected.txt patching file LayoutTests/media/media-fragments/TC0017-expected.txt patching file LayoutTests/media/media-fragments/TC0024-expected.txt patching file LayoutTests/media/media-fragments/TC0035-expected.txt patching file LayoutTests/media/media-fragments/TC0036-expected.txt patching file LayoutTests/media/media-fragments/TC0037-expected.txt patching file LayoutTests/media/media-fragments/TC0038-expected.txt patching file LayoutTests/media/media-fragments/TC0039-expected.txt patching file LayoutTests/media/media-fragments/TC0051-expected.txt patching file LayoutTests/media/media-fragments/TC0052-expected.txt patching file LayoutTests/media/media-fragments/TC0053-expected.txt patching file LayoutTests/media/media-fragments/TC0054-expected.txt patching file LayoutTests/media/media-fragments/TC0055-expected.txt patching file LayoutTests/media/media-fragments/TC0059-expected.txt patching file LayoutTests/media/media-fragments/TC0072-expected.txt patching file LayoutTests/media/media-fragments/TC0078-expected.txt patching file LayoutTests/media/media-fragments/TC0079-expected.txt patching file LayoutTests/media/media-fragments/TC0080-expected.txt patching file LayoutTests/media/media-fragments/TC0081-expected.txt patching file LayoutTests/media/media-fragments/TC0085-expected.txt patching file LayoutTests/media/media-fragments/TC0086-expected.txt patching file LayoutTests/media/media-fragments/TC0087-expected.txt patching file LayoutTests/media/media-fragments/TC0088-expected.txt patching file LayoutTests/media/media-fragments/TC0089-expected.txt patching file LayoutTests/media/media-fragments/TC0090-expected.txt patching file LayoutTests/media/media-fragments/TC0091-expected.txt patching file LayoutTests/media/media-fragments/media-fragments.js patching file LayoutTests/platform/gtk/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12692102

Charlie Turner

Comment 16 2019-07-08 13:07:39 PDT

Created attachment 373660 [details] Patch for landing

WebKit Commit Bot

Comment 17 2019-07-08 13:51:17 PDT

Comment on attachment 373660 [details] Patch for landing Clearing flags on attachment: 373660 Committed r247229: <https://trac.webkit.org/changeset/247229>

WebKit Commit Bot

Comment 18 2019-07-08 13:51:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.