Bug 132195

Summary: Allow a platform-specific size enumeration to be passed into popup-menu display
Product: WebKit Reporter: Dean Jackson <dino>
Component: FormsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Updated patch for building none

Dean Jackson
Reported 2014-04-25 08:17:10 PDT
Allow a platform-specific size enumeration to be passed into popup-menu display
Attachments
Patch (20.70 KB, patch)
2014-04-25 08:31 PDT, Dean Jackson 		bfulgham: review+
DetailsFormatted DiffDiff
Updated patch for building (19.60 KB, patch)
2014-04-25 11:12 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-04-25 08:31:31 PDT
Created attachment 230181 [details] Patch
Dean Jackson
Comment 2 2014-04-25 08:32:40 PDT
This will fail to compile due to required changes in WebKitSystemInterface. <rdar://problem/16175750>
Brent Fulgham
Comment 3 2014-04-25 09:50:09 PDT
Comment on attachment 230181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review r=me. It looks like no similar changes are needed for iOS, right? > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:38 > +void WebPopupMenu::setUpPlatformData(const IntRect& pageRect, PlatformPopupMenuData& data) It doesn't seem like you use pageRect anywhere.
Dean Jackson
Comment 4 2014-04-25 11:00:47 PDT
(In reply to comment #3) > (From update of attachment 230181 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review > > r=me. It looks like no similar changes are needed for iOS, right? No. iOS uses something completely different for popup menus.
Dean Jackson
Comment 5 2014-04-25 11:12:53 PDT
Created attachment 230188 [details] Updated patch for building
Dean Jackson
Comment 6 2014-04-25 14:43:30 PDT
Committed r167825: <http://trac.webkit.org/changeset/167825>
Brent Fulgham
Comment 7 2014-04-29 16:45:16 PDT
Comment on attachment 230188 [details] Updated patch for building Clearing review flag so it doesn't show up in the Request Queue.
Note You need to log in before you can comment on or make changes to this bug.