| Summary: | Allow a platform-specific size enumeration to be passed into popup-menu display | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||
| Component: | Forms | Assignee: | Dean Jackson <dino> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dean Jackson
2014-04-25 08:17:10 PDT
Created attachment 230181 [details]
Patch
This will fail to compile due to required changes in WebKitSystemInterface. <rdar://problem/16175750> Comment on attachment 230181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review r=me. It looks like no similar changes are needed for iOS, right? > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:38 > +void WebPopupMenu::setUpPlatformData(const IntRect& pageRect, PlatformPopupMenuData& data) It doesn't seem like you use pageRect anywhere. (In reply to comment #3) > (From update of attachment 230181 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review > > r=me. It looks like no similar changes are needed for iOS, right? No. iOS uses something completely different for popup menus. Created attachment 230188 [details]
Updated patch for building
Committed r167825: <http://trac.webkit.org/changeset/167825> Comment on attachment 230188 [details]
Updated patch for building
Clearing review flag so it doesn't show up in the Request Queue.
|