Bug 132177

Summary:

AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145646

Attachments:

Description	Flags
patch	none
patch	none

James Craig

Reported 2014-04-25 01:04:19 PDT

AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined. http://rawgit.com/w3c/aria/master/spec/aria.html @aria-orientation is now supported on the following roles (default values per role listed in parens) - combobox (vertical) - listbox (vertical) - menu (vertical) - menubar (horizontal) - radiogroup (undefined) - separator (horizontal) - scrollbar (vertical) - tablist (horizontal) - toolbar (horizontal) - tree (vertical) - treegrid (undefined)

Attachments
patch (15.53 KB, patch) 2015-10-06 12:18 PDT, Nan Wang	no flags	Details Formatted Diff Diff
patch (15.92 KB, patch) 2015-10-06 13:54 PDT, Nan Wang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-04-25 01:04:51 PDT

<rdar://problem/16723036>

Nan Wang

Comment 2 2015-10-06 12:18:09 PDT

Created attachment 262534 [details] patch

chris fleizach

Comment 3 2015-10-06 12:48:47 PDT

Comment on attachment 262534 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=262534&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2725 > + if (isScrollbar() these seem short enough they could go on one line > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2732 > + if (isMenuBar() these seem short enough they could go on one line > LayoutTests/accessibility/mac/aria-orientation.html:78 > + shouldBe("slider2.orientation", "'AXOrientation: '"); it seems like we should probably return a value for undefined

Nan Wang

Comment 4 2015-10-06 13:54:39 PDT

Created attachment 262544 [details] patch

WebKit Commit Bot

Comment 5 2015-10-06 14:46:39 PDT

Comment on attachment 262544 [details] patch Clearing flags on attachment: 262544 Committed r190648: <http://trac.webkit.org/changeset/190648>

WebKit Commit Bot

Comment 6 2015-10-06 14:46:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.