Bug 132177

Summary: AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145646    
Attachments:
Description Flags
patch
none
patch none

Description James Craig 2014-04-25 01:04:19 PDT 
AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.

http://rawgit.com/w3c/aria/master/spec/aria.html

@aria-orientation is now supported on the following roles (default values per role listed in parens)

- combobox (vertical)
- listbox (vertical)
- menu (vertical)
- menubar (horizontal)
- radiogroup (undefined)
- separator (horizontal)
- scrollbar (vertical)
- tablist (horizontal)
- toolbar (horizontal)
- tree (vertical)
- treegrid (undefined)
Comment 1 Radar WebKit Bug Importer 2014-04-25 01:04:51 PDT 
<rdar://problem/16723036>
Comment 2 Nan Wang 2015-10-06 12:18:09 PDT 
Created attachment 262534 [details]
patch
Comment 3 chris fleizach 2015-10-06 12:48:47 PDT 
Comment on attachment 262534 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262534&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2725
> +    if (isScrollbar()

these seem short enough they could go on one line

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2732
> +    if (isMenuBar()

these seem short enough they could go on one line

> LayoutTests/accessibility/mac/aria-orientation.html:78
> +          shouldBe("slider2.orientation", "'AXOrientation: '");

it seems like we should probably return a value for undefined
Comment 4 Nan Wang 2015-10-06 13:54:39 PDT 
Created attachment 262544 [details]
patch
Comment 5 WebKit Commit Bot 2015-10-06 14:46:39 PDT 
Comment on attachment 262544 [details]
patch

Clearing flags on attachment: 262544

Committed r190648: <http://trac.webkit.org/changeset/190648>
Comment 6 WebKit Commit Bot 2015-10-06 14:46:43 PDT 
All reviewed patches have been landed.  Closing bug.