Bug 132151

Summary: Mark Supplement instead of RefCountedSupplement in NavigatorContentUtils
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2014-04-24 15:35:05 PDT
Though NavigatorContentUtils didn't have any scenario which can be shared across navigator instances, it has used RefCountedSupplement. So, we need to use Supplement<Page> instead of RefCountedSupplement<>.
Attachments
Patch (4.37 KB, patch)
2014-04-24 15:47 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-04-24 15:39:23 PDT
(In reply to comment #0) > Though NavigatorContentUtils didn't have any scenario which can be shared across navigator instances, it has used RefCountedSupplement. So, we need to use Supplement<Page> instead of RefCountedSupplement<>. s/across navigator instances/across page instances/g It was considered to make the NavigatorContentUtils shareable across navigator instances. However, it has used RefCountedSupplement<Page> instead of RefCountedSupplement<Navigator>.
Gyuyoung Kim
Comment 2 2014-04-24 15:47:22 PDT
Created attachment 230114 [details] Patch
Darin Adler
Comment 3 2014-04-24 17:14:21 PDT
Comment on attachment 230114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58 > + static PassOwnPtr<NavigatorContentUtils> create(std::unique_ptr<NavigatorContentUtilsClient>); Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to fix all Supplement implementers at once.
Gyuyoung Kim
Comment 4 2014-04-24 20:31:57 PDT
(In reply to comment #3) > (From update of attachment 230114 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review > > > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58 > > + static PassOwnPtr<NavigatorContentUtils> create(std::unique_ptr<NavigatorContentUtilsClient>); > > Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to fix all Supplement implementers at once. Yes, I also wanna to it at once. I'm gonna file a bug for it.
WebKit Commit Bot
Comment 5 2014-04-24 21:00:14 PDT
Comment on attachment 230114 [details] Patch Clearing flags on attachment: 230114 Committed r167789: <http://trac.webkit.org/changeset/167789>
WebKit Commit Bot
Comment 6 2014-04-24 21:00:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.