Bug 132147

Summary: REGRESSION: Apparent hang of PCE.js Mac OS System 7.0.1 on ARM64 devices
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch
mhahnenberg: review+
Patch with test added mark.lam: review+

Michael Saboff
Reported 2014-04-24 15:15:18 PDT
This is fundamentally an 68K instruction emulator. Tracked the issue to MacroAssemblerARM64.h where we inadvertently use the destination register for both the source and destination in two arg or64(), eor32( ) and eor64().
Attachments
Patch (2.09 KB, patch)
2014-04-24 15:20 PDT, Michael Saboff 		mhahnenberg: review+
DetailsFormatted DiffDiff
Patch with test added (2.89 KB, patch)
2014-04-24 16:56 PDT, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-04-24 15:20:29 PDT
Created attachment 230111 [details] Patch
Mark Hahnenberg
Comment 2 2014-04-24 15:22:52 PDT
Comment on attachment 230111 [details] Patch r=me. Is it possible to write a test?
Michael Saboff
Comment 3 2014-04-24 15:42:51 PDT
(In reply to comment #2) > (From update of attachment 230111 [details]) > r=me. Is it possible to write a test? I think so. I'll spend some time to see if I can come up with one.
Michael Saboff
Comment 4 2014-04-24 16:56:44 PDT
Created attachment 230118 [details] Patch with test added
Mark Lam
Comment 5 2014-04-24 17:04:03 PDT
Comment on attachment 230118 [details] Patch with test added r=me
Michael Saboff
Comment 6 2014-04-24 17:14:46 PDT
Committed r167782: <http://trac.webkit.org/changeset/167782>
Note You need to log in before you can comment on or make changes to this bug.