Bug 132147

Summary: REGRESSION: Apparent hang of PCE.js Mac OS System 7.0.1 on ARM64 devices
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch
mhahnenberg: review+
Patch with test added mark.lam: review+

Description Michael Saboff 2014-04-24 15:15:18 PDT 
This is fundamentally an 68K instruction emulator.  Tracked the issue to MacroAssemblerARM64.h where we inadvertently use the destination register for both the source and destination in two arg or64(),  eor32( ) and eor64().
Comment 1 Michael Saboff 2014-04-24 15:20:29 PDT 
Created attachment 230111 [details]
Patch
Comment 2 Mark Hahnenberg 2014-04-24 15:22:52 PDT 
Comment on attachment 230111 [details]
Patch

r=me. Is it possible to write a test?
Comment 3 Michael Saboff 2014-04-24 15:42:51 PDT 
(In reply to comment #2)
> (From update of attachment 230111 [details])
> r=me. Is it possible to write a test?

I think so.  I'll spend some time to see if I can come up with one.
Comment 4 Michael Saboff 2014-04-24 16:56:44 PDT 
Created attachment 230118 [details]
Patch with test added
Comment 5 Mark Lam 2014-04-24 17:04:03 PDT 
Comment on attachment 230118 [details]
Patch with test added

r=me
Comment 6 Michael Saboff 2014-04-24 17:14:46 PDT 
Committed r167782: <http://trac.webkit.org/changeset/167782>