Bug 132131

Summary: [New Multicolumn] client rects don't work with spans
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch dino: review+

Description Dave Hyatt 2014-04-24 09:53:13 PDT
I should not have added in the offset of the multicolumn set in columnTranslationForOffset. This was already accounted for.
Comment 1 Dave Hyatt 2014-04-24 09:53:48 PDT
Created attachment 230087 [details]
Comment 2 WebKit Commit Bot 2014-04-24 09:55:32 PDT
Attachment 230087 [details] did not pass style-queue:

ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-04-24 09:55:50 PDT
Created attachment 230088 [details]
Comment 4 Dean Jackson 2014-04-24 09:58:01 PDT
Comment on attachment 230088 [details]

r+ but I think your image has the wrong mime type
Comment 5 Dave Hyatt 2014-04-24 10:03:09 PDT
Fixed in r167764.