Bug 132131 - [New Multicolumn] client rects don't work with spans
Summary: [New Multicolumn] client rects don't work with spans
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 09:53 PDT by Dave Hyatt
Modified: 2014-04-24 10:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (57.24 KB, patch)
2014-04-24 09:53 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (57.57 KB, patch)
2014-04-24 09:55 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-24 09:53:13 PDT 
I should not have added in the offset of the multicolumn set in columnTranslationForOffset. This was already accounted for.
Comment 1 Dave Hyatt 2014-04-24 09:53:48 PDT 
Created attachment 230087 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-24 09:55:32 PDT 
Attachment 230087 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-04-24 09:55:50 PDT 
Created attachment 230088 [details]
Patch
Comment 4 Dean Jackson 2014-04-24 09:58:01 PDT 
Comment on attachment 230088 [details]
Patch

r+ but I think your image has the wrong mime type
Comment 5 Dave Hyatt 2014-04-24 10:03:09 PDT 
Fixed in r167764.