Summary: | [EFL] WebKit build fails when MEDIA_SOURCE is enabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Praveen Jadhav <praveen.j> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bunhere, commit-queue, dev_sachin, gyuyoung.kim, lucas.de.marchi, rakuco, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Praveen Jadhav
2014-04-24 01:57:52 PDT
Created attachment 230066 [details]
Patch
PlatformEfl.cmake is modified to include MediaSourceGStreamer.cpp, SourceBufferPrivateGStreamer.cpp and WebKitMediaSourceGStreamer.cpp for compilation.
Comment on attachment 230066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230066&action=review It would be nice to move those file from PlatofrmGTK|EFL to CMakeLists.txt because GTK port also use it. However, we can't do that because wince port doesn't use it. > Source/WebCore/CMakeLists.txt:3111 > + "${WEBCORE_DIR}/platform/mock/mediasource" PlatformGTK.cmake also includes this path. I think you need to remove it from the PlatformGTK.cmake if you want to add the path to CMakeLists.txt But, wince port doesn't need to include this path. So, I think you need to move this to PlatformEfl.cmake as well. Created attachment 230074 [details]
Patch
Patch updated. All changes are included in PlatformEfl.cmake to ensure other bots are not affected.
Comment on attachment 230074 [details]
Patch
r=me. Are similar changes needed on Gtk?
Comment on attachment 230074 [details] Patch Clearing flags on attachment: 230074 Committed r167762: <http://trac.webkit.org/changeset/167762> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > (From update of attachment 230074 [details]) > r=me. Are similar changes needed on Gtk? Gtk already has these changes. |