WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around

• Component: WebKit2
• Status: RESOLVED FIXED

[Tim Horton]

So that we can persist a few other interesting properties, for future changes.

[Tim Horton]

Created attachment 230100 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 230100 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230100&action=review

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:89
> +#if USE(IOSURFACE)
> +        if (!snapshot->value.surface)
> +            continue;
> +#else
> +        if (!snapshot->value.image)
> +            continue;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:101
> +#if USE(IOSURFACE)
> +        snapshot->value.surface = nullptr;
> +#else
> +        snapshot->value.image = nullptr;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:122
> +#if USE(IOSURFACE)
> +    snapshot->value.surface = nullptr;
> +#else
> +    snapshot->value.image = nullptr;
> +#endif

Call said member function?

[Tim Horton]

http://trac.webkit.org/changeset/167775