Bug 132114

Summary: WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2014-04-24 01:35:02 PDT
So that we can persist a few other interesting properties, for future changes.
Attachments
patch (12.86 KB, patch)
2014-04-24 13:54 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-04-24 13:54:41 PDT
Created attachment 230100 [details] patch
Simon Fraser (smfr)
Comment 2 2014-04-24 14:19:40 PDT
Comment on attachment 230100 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230100&action=review > Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:89 > +#if USE(IOSURFACE) > + if (!snapshot->value.surface) > + continue; > +#else > + if (!snapshot->value.image) > + continue; > +#endif Put in a member function on Snapshot? > Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:101 > +#if USE(IOSURFACE) > + snapshot->value.surface = nullptr; > +#else > + snapshot->value.image = nullptr; > +#endif Put in a member function on Snapshot? > Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:122 > +#if USE(IOSURFACE) > + snapshot->value.surface = nullptr; > +#else > + snapshot->value.image = nullptr; > +#endif Call said member function?
Tim Horton
Comment 3 2014-04-24 14:46:39 PDT
http://trac.webkit.org/changeset/167775
Note You need to log in before you can comment on or make changes to this bug.