Bug 132114

Summary: WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Description Tim Horton 2014-04-24 01:35:02 PDT
So that we can persist a few other interesting properties, for future changes.
Comment 1 Tim Horton 2014-04-24 13:54:41 PDT
Created attachment 230100 [details]
patch
Comment 2 Simon Fraser (smfr) 2014-04-24 14:19:40 PDT
Comment on attachment 230100 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230100&action=review

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:89
> +#if USE(IOSURFACE)
> +        if (!snapshot->value.surface)
> +            continue;
> +#else
> +        if (!snapshot->value.image)
> +            continue;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:101
> +#if USE(IOSURFACE)
> +        snapshot->value.surface = nullptr;
> +#else
> +        snapshot->value.image = nullptr;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:122
> +#if USE(IOSURFACE)
> +    snapshot->value.surface = nullptr;
> +#else
> +    snapshot->value.image = nullptr;
> +#endif

Call said member function?
Comment 3 Tim Horton 2014-04-24 14:46:39 PDT
http://trac.webkit.org/changeset/167775