Bug 132110

Summary: FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, dino, enrica, esprehn+autocc, glenn, gyuyoung.kim, jonlee, macpherson, menard, mitz, sergio, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Myles C. Maxfield
Reported 2014-04-24 00:02:26 PDT
FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
Attachments
Patch (33.67 KB, patch)
2014-04-24 00:05 PDT, Myles C. Maxfield 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-04-24 00:05:41 PDT
Created attachment 230054 [details] Patch
Tim Horton
Comment 2 2014-04-24 00:38:06 PDT
Comment on attachment 230054 [details] Patch Nice! Did you make sure that iOS build doesn't break too? (seems like you're probably safe)
Myles C. Maxfield
Comment 3 2014-04-24 12:04:02 PDT
Yep! iOS builds fine.
Myles C. Maxfield
Comment 4 2014-04-24 12:06:41 PDT
http://trac.webkit.org/changeset/167768
Note You need to log in before you can comment on or make changes to this bug.