Bug 132085

Summary:

Eliminate internals.setMockScrollbarsEnabled()

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

72195

Bug Blocks:

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2014-04-23 15:44:02 PDT

Only Chromium wanted this, for no particular reason.

There are no tests that change this setting (except for resetting it to true, which it is already), and it can't work on some ports, because it's too late to change scrollbar type after a view is created.

Comment 1 Alexey Proskuryakov 2014-04-23 15:53:44 PDT

Created attachment 230015 [details]
proposed patch

Comment 2 Tim Horton 2014-04-23 16:11:02 PDT

What about WebKitTestRunner!?

Comment 3 Tim Horton 2014-04-23 16:11:23 PDT

Oh, I guess its call to enable scrollbars is shared, nevermind.

Comment 4 WebKit Commit Bot 2014-04-23 17:32:43 PDT

Comment on attachment 230015 [details]
proposed patch

Clearing flags on attachment: 230015

Committed r167732: <http://trac.webkit.org/changeset/167732>

Comment 5 WebKit Commit Bot 2014-04-23 17:32:47 PDT

All reviewed patches have been landed.  Closing bug.