Bug 132085

Summary: Eliminate internals.setMockScrollbarsEnabled()
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72195    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2014-04-23 15:44:02 PDT
Only Chromium wanted this, for no particular reason. There are no tests that change this setting (except for resetting it to true, which it is already), and it can't work on some ports, because it's too late to change scrollbar type after a view is created.
Attachments
proposed patch (16.00 KB, patch)
2014-04-23 15:53 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-04-23 15:53:44 PDT
Created attachment 230015 [details] proposed patch
Tim Horton
Comment 2 2014-04-23 16:11:02 PDT
What about WebKitTestRunner!?
Tim Horton
Comment 3 2014-04-23 16:11:23 PDT
Oh, I guess its call to enable scrollbars is shared, nevermind.
WebKit Commit Bot
Comment 4 2014-04-23 17:32:43 PDT
Comment on attachment 230015 [details] proposed patch Clearing flags on attachment: 230015 Committed r167732: <http://trac.webkit.org/changeset/167732>
WebKit Commit Bot
Comment 5 2014-04-23 17:32:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.