Bug 132085 - Eliminate internals.setMockScrollbarsEnabled()
Summary: Eliminate internals.setMockScrollbarsEnabled()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on: 72195
  Show dependency treegraph
Reported: 2014-04-23 15:44 PDT by Alexey Proskuryakov
Modified: 2014-04-23 17:32 PDT (History)
8 users (show)

See Also:

proposed patch (16.00 KB, patch)
2014-04-23 15:53 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-23 15:44:02 PDT
Only Chromium wanted this, for no particular reason.

There are no tests that change this setting (except for resetting it to true, which it is already), and it can't work on some ports, because it's too late to change scrollbar type after a view is created.
Comment 1 Alexey Proskuryakov 2014-04-23 15:53:44 PDT
Created attachment 230015 [details]
proposed patch
Comment 2 Tim Horton 2014-04-23 16:11:02 PDT
What about WebKitTestRunner!?
Comment 3 Tim Horton 2014-04-23 16:11:23 PDT
Oh, I guess its call to enable scrollbars is shared, nevermind.
Comment 4 WebKit Commit Bot 2014-04-23 17:32:43 PDT
Comment on attachment 230015 [details]
proposed patch

Clearing flags on attachment: 230015

Committed r167732: <http://trac.webkit.org/changeset/167732>
Comment 5 WebKit Commit Bot 2014-04-23 17:32:47 PDT
All reviewed patches have been landed.  Closing bug.