[GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer... (pid=30953)
**
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:241:void openRemoteDebuggingSession(InspectorServerTest*, gconstpointer): assertion failed: (javascriptResult)
GTester: last random seed: R02S76a375c7b7e9a9fb04f17fded1d0cf78
(pid=31125)
FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer
Tests failed (1): WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer

[Philippe Normand]

I'm starting a patch.

[Carlos Garcia Campos]

I think one of the problems is that in r164543 the order of the scripts in Main.html changed. One of the problems I see in the console is:

ReferenceError: Can't find variable: InspectorFrontendHost

That happens in Platform.js, because InspectorFrontendHostStub.js hasn't been loaded yet. With the local inspector doesn't happen because the InspectorFrontendHost is injected directly from the code on window object cleared. There might be more errors like this, I also see 'IndexedDB' domain was not found, not sure that was if fatal, though.

[Carlos Garcia Campos]

Created attachment 239787 [details]
Patch

The inspector still doesn't work because of bug #137340, but reverting r174025 and applying this patch makes the remote inspector work again and the test to pass.

[Brian Burg]

(In reply to comment #2)
> I think one of the problems is that in r164543 the order of the scripts in
> Main.html changed. One of the problems I see in the console is:
> 
> ReferenceError: Can't find variable: InspectorFrontendHost
> 
> That happens in Platform.js, because InspectorFrontendHostStub.js hasn't
> been loaded yet. With the local inspector doesn't happen because the
> InspectorFrontendHost is injected directly from the code on window object
> cleared. There might be more errors like this, I also see 'IndexedDB' domain
> was not found, not sure that was if fatal, though.

It should be able to fail cleanly with no IndexedDB domain, since it's an optional feature. If the inspector or tests break with !ENABLE(INDEXED_DATABASE) please file a bug.

[Carlos Garcia Campos]

Committed r174926: <http://trac.webkit.org/changeset/174926>