Bug 131983

Summary: [GTK] Crash after getting web view context property with g_object_get
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, mrobinson, pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2014-04-22 05:07:17 PDT
The problem is that the getter is using g_value_take_object() and the default context is destroyed when the caller releases its ref. We should use g_value_set_object instead.
Attachments
Patch (1.44 KB, patch)
2014-04-22 05:09 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-04-22 05:09:12 PDT
Created attachment 229875 [details] Patch
WebKit Commit Bot
Comment 2 2014-04-22 05:10:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2014-04-22 06:36:55 PDT
Committed r167656: <http://trac.webkit.org/changeset/167656>
Note You need to log in before you can comment on or make changes to this bug.