Bug 131980

Summary:

Buildfix after r167650 broke non-Cocoa builds

Product:

WebKit

Reporter:

Peter Molnar <pmolnar.u-szeged>

Component:

WebCore Misc.

Assignee:

Peter Molnar <pmolnar.u-szeged>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, mario

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	pnormand: review-, commit-queue: commit-queue-

Peter Molnar

Reported 2014-04-22 02:39:32 PDT

Buildfix after r167650 broke non-Cocoa builds

Attachments
patch (735 bytes, patch) 2014-04-22 02:42 PDT, Peter Molnar	pnormand: review- commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Peter Molnar

Comment 1 2014-04-22 02:42:56 PDT

Created attachment 229873 [details] patch #ifdef-ed out the Mac specific line to fix the non-Cocoa builds.

Mario Sanchez Prada

Comment 2 2014-04-22 02:47:43 PDT

Comment on attachment 229873 [details] patch Sounds good to me, although we should let bfulgham now about it anyway

WebKit Commit Bot

Comment 3 2014-04-22 03:17:23 PDT

Comment on attachment 229873 [details] patch Rejecting attachment 229873 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 229873, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 131980. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/4802375017562112

Philippe Normand

Comment 4 2014-04-22 03:45:21 PDT

Comment on attachment 229873 [details] patch Missing ChangeLog, prepare-ChangeLog can help with that.

Mario Sanchez Prada

Comment 5 2014-04-22 03:56:56 PDT

(In reply to comment #4) > (From update of attachment 229873 [details]) > Missing ChangeLog, prepare-ChangeLog can help with that. Opps, that's right. Sorry for my quick review

Peter Molnar

Comment 6 2014-04-22 04:05:40 PDT

(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 229873 [details] [details]) > > Missing ChangeLog, prepare-ChangeLog can help with that. > > Opps, that's right. Sorry for my quick review Sorry, added the ChangeLog and landed patch in r167654.

Note You need to log in before you can comment on or make changes to this bug.