Bug 131978

Summary: Frame::document() should return a reference
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: FramesAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: NEW    
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
gyuyoung.kim: commit-queue-
WIP gyuyoung.kim: commit-queue-

Gyuyoung Kim
Reported 2014-04-22 02:15:54 PDT
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=131652#c3, frame should always have a document. So, we can return a reference in frame.
Attachments
WIP (394.79 KB, patch)
2014-04-22 02:17 PDT, Gyuyoung Kim 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
WIP (425.04 KB, patch)
2014-04-22 21:54 PDT, Gyuyoung Kim 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-04-22 02:17:42 PDT
Created attachment 229872 [details] WIP
Gyuyoung Kim
Comment 2 2014-04-22 02:19:16 PDT
Kling, I wonder if there is any chance that a frame has a null document.
Gyuyoung Kim
Comment 3 2014-04-22 21:54:26 PDT
Created attachment 229953 [details] WIP
Andreas Kling
Comment 4 2014-04-22 22:53:55 PDT
Frame::document() will be null when the Frame is created, until the FrameLoader has completed loading the initial document. It will also become null during teardown. We shouldn't make document() return a reference until we've eliminated those cases where it can be null.
Gyuyoung Kim
Comment 5 2014-04-22 22:57:23 PDT
(In reply to comment #4) > Frame::document() will be null when the Frame is created, until the FrameLoader has completed loading the initial document. It will also become null during teardown. > > We shouldn't make document() return a reference until we've eliminated those cases where it can be null. Kling, thank you for your answer. Let me check those cases.
Note You need to log in before you can comment on or make changes to this bug.