Bug 131969 – [WebKit2] Cleanup the build from unused parameter in UIProcess Module

• Component: WebKit2
• Status: RESOLVED FIXED

[Shivakumar J M]

Found unused parameter in UIProcess Module during webkit-efl port build. These issue seems to be introduced by issue https://bugs.webkit.org/show_bug.cgi?id=131776, need to confirm with Alice once

/home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/UIProcess/WebFindClient.cpp:33:6: warning: unused parameter ‘matchIndex’ [-Wunused-parameter]
 void WebFindClient::didFindString(WebPageProxy* page, const String& string, uint32_t matchCount, int32_t matchIndex)
      ^
[ 88%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebFramePolicyListenerProxy.cpp.o

[ 89%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/C/WKPreferences.cpp.o
/home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/UIProcess/API/C/WKPage.cpp:709:22: warning: unused parameter ‘matchIndex’ [-Wunused-parameter]
         virtual void didFindString(WebPageProxy* page, const String& string, uint32_t matchCount, int32_t matchIndex) override
                      ^
[ 89%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/C/WKProtectionSpace.cpp.o

[Shivakumar J M]

Created attachment 230888 [details]
Fix unused parameter by using UNUSED_PARAM macro

Fix unused parameter by using UNUSED_PARAM macro

[WebKit Commit Bot]

Attachment 230888 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shivakumar J M]

Comment on attachment 230888 [details]
Fix unused parameter by using UNUSED_PARAM macro

>Index: Source/WebKit2/ChangeLog
>===================================================================
>--- Source/WebKit2/ChangeLog	(revision 168348)
>+++ Source/WebKit2/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>[phone]  Shivakumar JM  <[e-mail]>
>+
>+        Cleanup the build from unused parameter in UIProcess Module
>+        https://bugs.webkit.org/show_bug.cgi?id=131969
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix unused parameter by using UNUSED_PARAM macro
>+
>+        * UIProcess/API/C/WKPage.cpp:
>+        (WKPageSetPageFindClient):
>+        * UIProcess/WebFindClient.cpp:
>+        (WebKit::WebFindClient::didFindString):
>+
> 2014-05-05  Jeremy Jones  <[e-mail]>
> 
>         Implement scan backward and forward in video fullscreen.
>Index: Source/WebKit2/UIProcess/WebFindClient.cpp
>===================================================================
>--- Source/WebKit2/UIProcess/WebFindClient.cpp	(revision 168348)
>+++ Source/WebKit2/UIProcess/WebFindClient.cpp	(working copy)
>@@ -32,6 +32,8 @@ namespace WebKit {
> 
> void WebFindClient::didFindString(WebPageProxy* page, const String& string, uint32_t matchCount, int32_t matchIndex)
> {
>+    UNUSED_PARAM(matchIndex);
>+
>     if (!m_client.didFindString)
>         return;
> 
>Index: Source/WebKit2/UIProcess/API/C/WKPage.cpp
>===================================================================
>--- Source/WebKit2/UIProcess/API/C/WKPage.cpp	(revision 168348)
>+++ Source/WebKit2/UIProcess/API/C/WKPage.cpp	(working copy)
>@@ -704,6 +704,8 @@ void WKPageSetPageFindClient(WKPageRef p
>     private:
>         virtual void didFindString(WebPageProxy* page, const String& string, uint32_t matchCount, int32_t matchIndex) override
>         {
>+            UNUSED_PARAM(matchIndex);
>+
>             if (!m_client.didFindString)
>                 return;
>             
>Index: LayoutTests/ChangeLog
>===================================================================

[Shivakumar J M]

Created attachment 230895 [details]
Patch

Fix unused parameter by using UNUSED_PARAM macro, uploaded new patch again, since some problem was there in create patch for first time.

[Csaba Osztrogonác]

Comment on attachment 230895 [details]
Patch

In WebKit style we prefer omitting the name of the argument to UNUSED_PARAM.

[Shivakumar J M]

Created attachment 230896 [details]
Patch

Fixed unused parameter by omitting the parameter name, updated the patch with review comments

[WebKit Commit Bot]

Comment on attachment 230896 [details]
Patch

Clearing flags on attachment: 230896

Committed r168419: <http://trac.webkit.org/changeset/168419>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shivakumar J M]

Bug is fixed, tested in version 168886.

[Csaba Osztrogonác]

Please don't change resolved/fixed state of the bugs.
See https://bugs.webkit.org/show_bug.cgi?id=133062#c7 for details.