Summary: | REGRESSION (r157328): popover to check into flight ba.com dismisses instantly when focusing form | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
Component: | UI Events | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, benjamin, buildbot, commit-queue, darin, esprehn+autocc, kangil.han, kling, koivisto, rniwa, sam | ||||||||||
Priority: | P2 | Keywords: | Regression | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 122680 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2014-04-21 13:43:38 PDT
Created attachment 229863 [details]
Fixes the bug
Comment on attachment 229863 [details] Fixes the bug Attachment 229863 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6027582352916480 New failing tests: fast/events/shadow-event-path.html Created attachment 229864 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 229863 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=229863&action=review Patch seems fine, but I find the indirect way all this code is written really confusing. The new test seems to be failing on EWS, so please check to be sure that’s resolved before landing. > Source/WebCore/dom/EventDispatcher.cpp:180 > + Node* previousHost = 0; nullptr > Source/WebCore/dom/EventDispatcher.cpp:192 > + return 0; nullptr Created attachment 229916 [details]
Patch for landing
Created attachment 229917 [details]
Patch for landing
Comment on attachment 229917 [details] Patch for landing Clearing flags on attachment: 229917 Committed r167689: <http://trac.webkit.org/changeset/167689> All reviewed patches have been landed. Closing bug. Committed r167744: <http://trac.webkit.org/changeset/167744> This caused bug 132214. (and apparently many more bugs) (In reply to comment #11) > (and apparently many more bugs) Where can I find out more about the “many more”? |