Bug 131940

Summary: Move the JSString cache from DOMWrapperWorld to VM.
Product: WebKit Reporter: Andreas Kling <kling>
Component: BindingsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Andreas Kling
Reported 2014-04-21 11:45:59 PDT
There's no need for the string cache to sit on the DOMWrapperWorld. The indirection to get there is pretty expensive, too.
Attachments
Patch (4.95 KB, patch)
2014-04-21 11:52 PDT, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-04-21 11:52:41 PDT
Created attachment 229816 [details] Patch
Geoffrey Garen
Comment 2 2014-04-21 12:12:25 PDT
Comment on attachment 229816 [details] Patch r=me Should probably move jsStringWithCache into JSC now -- maybe JSString.h? -- since the library that supplies the data structure might as well supply the function to access it.
Andreas Kling
Comment 3 2014-04-21 12:17:50 PDT
Committed r167605: <http://trac.webkit.org/changeset/167605>
Andreas Kling
Comment 4 2014-04-21 12:18:36 PDT
(In reply to comment #2) > (From update of attachment 229816 [details]) > r=me > > Should probably move jsStringWithCache into JSC now -- maybe JSString.h? -- since the library that supplies the data structure might as well supply the function to access it. Oh yeah, okay.
Note You need to log in before you can comment on or make changes to this bug.