| Summary: | Page::setDefersLoading doesn’t do anything when using the Network process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | WebKit2 | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, beidson, commit-queue, japhet, koivisto | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2014-04-21 11:21:24 PDT
Created attachment 229814 [details]
Add load deferring to NetworkResourceLoader
Comment on attachment 229814 [details] Add load deferring to NetworkResourceLoader View in context: https://bugs.webkit.org/attachment.cgi?id=229814&action=review Darin says: ''' The patch looks exactly right to me. ''' Maciej says: ''' Taking Darin's comment as an r+ and moving to Prepare. ''' > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:151 > + m_request = m_deferredRequest; > + m_deferredRequest = ResourceRequest(); Darin says: ''' We’d get better efficiency if we added a move assignment operator to ResourceRequest and used it there. ''' Comment on attachment 229814 [details] Add load deferring to NetworkResourceLoader Clearing flags on attachment: 229814 Committed r167635: <http://trac.webkit.org/changeset/167635> All reviewed patches have been landed. Closing bug. This was kind of intentional… What is the guarantee that calling setDefersLoading(true) provides now? |