Bug 131936

Summary:

http/tests/cache/subresource-failover-to-network.html is flaky

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2014-04-21 10:59:33 PDT

http/tests/cache/subresource-failover-to-network.html is buggy. It tries to use testRunner queueing, but what actually happens is:

- on first load, the test queues JS execution to submit a form, plus two history navigations.
- but when it navigates back to main page, the same script runs again, queuing the same sequence again!

And then it's nothing but pure luck that makes the test test pass on some platforms.

Also, the test sets a cookie and doesn't reset it, which is sad.

Comment 1 Alexey Proskuryakov 2014-04-21 11:05:50 PDT

Created attachment 229810 [details]
proposed fix

Comment 2 WebKit Commit Bot 2014-04-21 11:55:41 PDT

Comment on attachment 229810 [details]
proposed fix

Clearing flags on attachment: 229810

Committed r167601: <http://trac.webkit.org/changeset/167601>

Comment 3 WebKit Commit Bot 2014-04-21 11:55:43 PDT

All reviewed patches have been landed.  Closing bug.