Bug 131936

Summary: http/tests/cache/subresource-failover-to-network.html is flaky
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2014-04-21 10:59:33 PDT
http/tests/cache/subresource-failover-to-network.html is buggy. It tries to use testRunner queueing, but what actually happens is: - on first load, the test queues JS execution to submit a form, plus two history navigations. - but when it navigates back to main page, the same script runs again, queuing the same sequence again! And then it's nothing but pure luck that makes the test test pass on some platforms. Also, the test sets a cookie and doesn't reset it, which is sad.
Attachments
proposed fix (3.91 KB, patch)
2014-04-21 11:05 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-04-21 11:05:50 PDT
Created attachment 229810 [details] proposed fix
WebKit Commit Bot
Comment 2 2014-04-21 11:55:41 PDT
Comment on attachment 229810 [details] proposed fix Clearing flags on attachment: 229810 Committed r167601: <http://trac.webkit.org/changeset/167601>
WebKit Commit Bot
Comment 3 2014-04-21 11:55:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.