| Summary: | REGRESSION (r160908): Safari doesn't draw rotated images properly first time | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||
| Component: | Images | Assignee: | Darin Adler <darin> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | andersca, buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, japhet, kangil.han, kling, koivisto, rniwa, thorton | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Darin Adler
2014-04-21 00:25:02 PDT
Created attachment 229792 [details]
Patch
Regressions: Unexpected text-only failures (2) fast/images/favicon-as-image.html [ Failure ] http/tests/misc/favicon-as-image.html [ Failure ] Comment on attachment 229792 [details] Patch Attachment 229792 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6715599019311104 New failing tests: http/tests/misc/favicon-as-image.html fast/images/favicon-as-image.html Created attachment 229793 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 229792 [details] Patch Attachment 229792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5558055454375936 New failing tests: http/tests/misc/favicon-as-image.html fast/images/favicon-as-image.html Created attachment 229794 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 229792 [details] Patch Attachment 229792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6380866498461696 New failing tests: http/tests/misc/favicon-as-image.html fast/images/favicon-as-image.html Created attachment 229796 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 229805 [details]
Patch
Created attachment 229807 [details]
Patch
OK, should really be ready for review now. Committed r167598: <http://trac.webkit.org/changeset/167598> Comment on attachment 229807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229807&action=review > Source/WebCore/loader/FrameLoaderClient.h:306 > virtual bool allowRunningInsecureContent(bool enabledPerSettings, SecurityOrigin*, const URL&) { return enabledPerSettings; } Oops, forgot to delete this line. I have it deleted locally. I’ll do that in a follow-up if this gets landed by the commit queue. |