Summary: | [Mac] Unable to select 'Off' or 'Auto' from track menu when tracks consist of unsupported track types | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-04-19 22:17:48 PDT
Created attachment 229756 [details]
Patch
Comment on attachment 229756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229756&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3717 > + } else if (trackToSelect == TextTrack::captionMenuOffItem()) { I'm not sure if this would be better to just incorporate into the loop above? Comment on attachment 229756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229756&action=review > Source/WebCore/ChangeLog:10 > + (WebCore::HTMLMediaElement::parseAttribute): When the user selects 'Off', make sure the currently 'showing' prepare-ChangeLog doesn't like something about HTMLMediaElement.cpp so it thinks all changes are in parseAttribute, so you should fix this entry manually. >> Source/WebCore/html/HTMLMediaElement.cpp:3717 >> + } else if (trackToSelect == TextTrack::captionMenuOffItem()) { > > I'm not sure if this would be better to just incorporate into the loop above? It could be, but I think it is probably easier to follow the logic this way. > Source/WebCore/html/HTMLMediaElement.cpp:3720 > + if (!trackToSelect || track != trackToSelect) trackToSelect is TextTrack::captionMenuOffItem so it can't be NULL, and TextTrack::captionMenuOffItem won't be in textTracks(), so this check can be removed. Committed r167578: <http://trac.webkit.org/changeset/167578> |