Bug 131897

Summary: Inline allocate Arguments objects in the DFG
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Description Mark Hahnenberg 2014-04-19 13:56:29 PDT 
Many libraries/frameworks depend on the arguments object for overloaded API entry points. This is the first step to making Arguments fast(er). We'll duplicate the logic in Arguments::create for now, and take the slow path for complicated cases like slow arguments, tearing off for strict mode, etc.
Comment 1 Mark Hahnenberg 2014-04-19 13:59:50 PDT 
Created attachment 229745 [details]
Patch
Comment 2 Mark Hahnenberg 2014-04-19 14:40:23 PDT 
Created attachment 229748 [details]
Patch
Comment 3 Mark Hahnenberg 2014-04-19 14:46:04 PDT 
This is performance neutral on the benchmarks we track.
Comment 4 Geoffrey Garen 2014-04-19 16:06:02 PDT 
Comment on attachment 229748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229748&action=review

r=me

> Source/JavaScriptCore/runtime/Arguments.h:60
> +        

Revert.
Comment 5 Mark Hahnenberg 2014-04-21 08:12:07 PDT 
Committed r167591: <http://trac.webkit.org/changeset/167591>