| Summary: | bmalloc: Mutex should be harder to use wrong | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Geoffrey Garen
2014-04-18 21:05:12 PDT
Created attachment 229713 [details]
Patch
Attachment 229713 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/StaticMutex.h:40: try_lock is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/bmalloc/bmalloc/StaticMutex.h:60: StaticMutex::try_lock is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/bmalloc/bmalloc/StaticMutex.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 229713 [details]
Patch
r=me
Committed r167540: <http://trac.webkit.org/changeset/167540> |