Bug 131874

Summary: [iOS][WK2] Make dynamic viewport size update content aware
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Benjamin Poulain
Reported 2014-04-18 19:35:38 PDT
[iOS][WK2] Make dynamic viewport size update content aware
Attachments
Patch (13.17 KB, patch)
2014-04-18 19:58 PDT, Benjamin Poulain 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-04-18 19:58:21 PDT
Created attachment 229705 [details] Patch
Tim Horton
Comment 2 2014-04-18 21:13:36 PDT
Comment on attachment 229705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229705&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1777 > + m_dynamicSizeUpdateHistory.add(std::pair<IntSize, float>(oldContentSize, oldPageScaleFactor), IntPoint(frameView.scrollOffset())); I think you can use make_pair with no template arguments? > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1794 > + Frame& containingFrame = *node->document().frame(); why the containingFrame temporary? > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1848 > + const auto& previousPosition = m_dynamicSizeUpdateHistory.find(std::pair<IntSize, float>(newContentSize, scale)); ditto
Benjamin Poulain
Comment 3 2014-04-21 13:11:10 PDT
Committed r167614: <http://trac.webkit.org/changeset/167614>
Note You need to log in before you can comment on or make changes to this bug.