Bug 131874

Summary:

[iOS][WK2] Make dynamic viewport size update content aware

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enrica, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Benjamin Poulain 2014-04-18 19:35:38 PDT

[iOS][WK2] Make dynamic viewport size update content aware

Comment 1 Benjamin Poulain 2014-04-18 19:58:21 PDT

Created attachment 229705 [details]
Patch

Comment 2 Tim Horton 2014-04-18 21:13:36 PDT

Comment on attachment 229705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229705&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1777
> +    m_dynamicSizeUpdateHistory.add(std::pair<IntSize, float>(oldContentSize, oldPageScaleFactor), IntPoint(frameView.scrollOffset()));

I think you can use make_pair with no template arguments?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1794
> +                Frame& containingFrame = *node->document().frame();

why the containingFrame temporary?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1848
> +        const auto& previousPosition = m_dynamicSizeUpdateHistory.find(std::pair<IntSize, float>(newContentSize, scale));

ditto

Comment 3 Benjamin Poulain 2014-04-21 13:11:10 PDT

Committed r167614: <http://trac.webkit.org/changeset/167614>