Bug 131852

Summary: Correct some issues small issues in WK2 file upload InjectedBundle APIs
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-04-18 12:48:13 PDT
There are some minor issues in WK2 file upload injected bundle APIs. - the default for shouldGenerateFileForUpload should return a null string, not an empty string. null string is special. - an injected bundle API is pre-checking the wrong function
Attachments
[PATCH] Proposed Fix (3.05 KB, patch)
2014-04-18 12:50 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-04-18 12:50:00 PDT
Created attachment 229666 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2014-04-18 13:44:15 PDT
Comment on attachment 229666 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=229666&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:60 > virtual WTF::String generateFileForUpload(WebKit::WebPage*, const WTF::String& originalFilePath) { UNUSED_PARAM(originalFilePath); return emptyString(); } I suppose this could also return a null string. However null string is only really important in should. As null string => should not, but anything else => should.
WebKit Commit Bot
Comment 3 2014-04-18 16:11:34 PDT
Comment on attachment 229666 [details] [PATCH] Proposed Fix Clearing flags on attachment: 229666 Committed r167514: <http://trac.webkit.org/changeset/167514>
WebKit Commit Bot
Comment 4 2014-04-18 16:11:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.