Bug 131851

Summary: bmalloc: Added an XSmall line size
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: REOPENED ---    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Geoffrey Garen 2014-04-18 12:35:46 PDT 
bmalloc: Added an XSmall line size
Comment 1 Geoffrey Garen 2014-04-18 12:44:07 PDT 
Created attachment 229665 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-18 12:45:22 PDT 
Attachment 229665 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Heap.cpp:141:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-04-18 13:18:22 PDT 
Committed r167502: <http://trac.webkit.org/changeset/167502>
Comment 4 Geoffrey Garen 2014-04-19 13:41:14 PDT 
This caused a large object validation ASSERT on the Facebook benchmark in debug builds. Most likely, it just exposed a pre-existing large object bug by moving more objects into the large object space.
Comment 5 Geoffrey Garen 2014-04-19 13:42:03 PDT 
Rolled out in <http://trac.webkit.org/changeset/167546>.
Comment 6 Geoffrey Garen 2014-05-10 12:47:48 PDT 
Comment on attachment 229665 [details]
Patch

Clearing review flag to remove this from the landing queue.