Bug 131850

Summary:

Options::maximumExecutionCountsBetweenCheckpoints() should be higher for DFG->FTL tier-up but the same for other tier-ups

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Filip Pizlo 2014-04-18 12:34:44 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-04-18 12:36:06 PDT

Created attachment 229664 [details]
the patch

Comment 2 Mark Hahnenberg 2014-04-18 13:03:32 PDT

Comment on attachment 229664 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229664&action=review

r=me after tests + perf numbers come back green :-)

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:90
> +    default:
> +        RELEASE_ASSERT_NOT_REACHED();

Some platforms might complain about clippedValue not being defined prior to use here. You might want to set it to some bogus value in this branch.

Comment 3 Filip Pizlo 2014-04-18 16:21:07 PDT

Landed in http://trac.webkit.org/changeset/167515