Bug 131850

Summary: Options::maximumExecutionCountsBetweenCheckpoints() should be higher for DFG->FTL tier-up but the same for other tier-ups
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2014-04-18 12:34:44 PDT
Patch forthcoming.
Attachments
the patch (16.63 KB, patch)
2014-04-18 12:36 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-04-18 12:36:06 PDT
Created attachment 229664 [details] the patch
Mark Hahnenberg
Comment 2 2014-04-18 13:03:32 PDT
Comment on attachment 229664 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=229664&action=review r=me after tests + perf numbers come back green :-) > Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:90 > + default: > + RELEASE_ASSERT_NOT_REACHED(); Some platforms might complain about clippedValue not being defined prior to use here. You might want to set it to some bogus value in this branch.
Filip Pizlo
Comment 3 2014-04-18 16:21:07 PDT
Landed in http://trac.webkit.org/changeset/167515
Note You need to log in before you can comment on or make changes to this bug.