Bug 131824

Summary:

[CSS Blending] Remove support for non-separable blend modes from mix-blend-mode

Product:

WebKit

Reporter:

Rik Cabanier <cabanier>

Component:

CSS

Assignee:

Rik Cabanier <cabanier>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

95614

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Rik Cabanier

Reported 2014-04-17 15:29:25 PDT

OSX and iOS don't support the non-separable blend modes (hue, saturation, color and luminosity) in composited mode. The spec (http://dev.w3.org/fxtf/compositing-1/#mix-blend-mode) is currently in CR but will be updated.

Attachments
Patch (17.85 KB, patch) 2014-04-17 16:52 PDT, Rik Cabanier	no flags	Details Formatted Diff Diff
Patch (18.77 KB, patch) 2014-04-21 10:56 PDT, Rik Cabanier	no flags	Details Formatted Diff Diff
Patch for landing (18.72 KB, patch) 2014-04-21 13:09 PDT, Rik Cabanier	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Rik Cabanier

Comment 1 2014-04-17 16:52:17 PDT

Created attachment 229598 [details] Patch

Dean Jackson

Comment 2 2014-04-18 09:04:52 PDT

Comment on attachment 229598 [details] Patch r=me but I suggest you remove the backend code as well. The stuff in BlahFiltersBlah that is empty code with a comment saying they are not implemented.

Rik Cabanier

Comment 3 2014-04-21 10:56:49 PDT

Created attachment 229808 [details] Patch

WebKit Commit Bot

Comment 4 2014-04-21 12:04:48 PDT

Comment on attachment 229808 [details] Patch Rejecting attachment 229808 [details] from review queue. cabanier@adobe.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.

Simon Fraser (smfr)

Comment 5 2014-04-21 12:28:51 PDT

Comment on attachment 229808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229808&action=review > Source/WebCore/ChangeLog:8 > + Removed support for non-sep blend modes from the CSS parser. Please don't abbreviate non-seperable.

Rik Cabanier

Comment 6 2014-04-21 13:09:03 PDT

Created attachment 229824 [details] Patch for landing

WebKit Commit Bot

Comment 7 2014-04-21 13:44:32 PDT

Comment on attachment 229824 [details] Patch for landing Clearing flags on attachment: 229824 Committed r167620: <http://trac.webkit.org/changeset/167620>

WebKit Commit Bot

Comment 8 2014-04-21 13:44:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.