Bug 131823

Summary:

FTL::fail() should manage memory "correctly"

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	oliver: review+

Filip Pizlo

Reported 2014-04-17 15:28:03 PDT

We have some objects that the DFG::Plan points to but that are owned by DFG::Graph until such time as they are owned by DFG::JITCode. It's weird, and a lot of this is a deeper spaghetti that needs to be fixed. But for now, at least make FTL::fail() follow the protocol for InlineCallFrames.

Attachments
the patch (1.21 KB, patch) 2014-04-17 15:29 PDT, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2014-04-17 15:29:31 PDT

Created attachment 229584 [details] the patch

Filip Pizlo

Comment 2 2014-04-17 15:31:38 PDT

Landed in http://trac.webkit.org/changeset/167456

Note You need to log in before you can comment on or make changes to this bug.