Bug 131813

Summary:

_webProcessIdentifier should return 0 if the web process crashed

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

New Bugs

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, mitz, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	andersca: review+

Description Pratik Solanki 2014-04-17 13:50:52 PDT

Add SPI to see if web process is live or got killed

Comment 1 Pratik Solanki 2014-04-17 13:52:05 PDT

Created attachment 229572 [details]
Patch

Comment 2 Anders Carlsson 2014-04-17 13:53:48 PDT

Comment on attachment 229572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229572&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1411
> +- (BOOL)_isValid
> +{
> +    return _page->isValid();
> +}

I think this name is too generic. How about _hasWebProcess?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:121
> +- (BOOL)_isValid;

This should be a property.

Comment 3 Pratik Solanki 2014-04-17 14:16:47 PDT

Better way - just make _webProcessIdentifier return 0 if the process was killed.

Comment 4 Pratik Solanki 2014-04-17 14:27:30 PDT

Created attachment 229577 [details]
Patch

Comment 5 Pratik Solanki 2014-04-17 15:39:55 PDT

Committed r167457: <http://trac.webkit.org/changeset/167457>