|Summary:||[New Multicolumn] fast/multicol/overflow-content.html displays red|
|Product:||WebKit||Reporter:||Dave Hyatt <hyatt>|
|Component:||Layout and Rendering||Assignee:||Morten Stenshorne <mstensho>|
|Severity:||Normal||CC:||commit-queue, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, mstensho, thorton, webkit-bug-importer, WebkitBugTracker|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Dave Hyatt 2014-04-17 13:39:22 PDT
Not clear if this is a test problem or if the new multi-column layout still has a bug. Will need to investigate the test to find out.
Comment 1 Dave Hyatt 2014-04-17 21:33:02 PDT
Test is fine. Balancing is getting confused by overflow, so this is a legitimate bug.
Comment 3 Dave Hyatt 2014-04-21 13:44:14 PDT
This is a blocker for turning the new columns on.
Comment 5 Morten Stenshorne 2014-04-22 17:42:13 PDT
overflow-content.html is flaky and the new one in newmulticol/compare-with-old-impl/ will need the fixes for bug 113781 and bug 113058 in order to pass reliably.
Comment 7 WebKit Commit Bot 2014-04-23 06:36:58 PDT
Comment on attachment 229931 [details] Patch Clearing flags on attachment: 229931 Committed r167707: <http://trac.webkit.org/changeset/167707>
Comment 8 WebKit Commit Bot 2014-04-23 06:37:02 PDT
All reviewed patches have been landed. Closing bug.
Comment 9 Alexey Proskuryakov 2014-04-23 10:17:11 PDT
This made fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html fail most of the time on several bots: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fmulticol%2Fnewmulticol%2Fcompare-with-old-impl%2Foverflow-content.html http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r167711%20(19379)/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-diffs.html
Comment 10 Alexey Proskuryakov 2014-04-23 10:20:32 PDT
(In reply to comment #5) > overflow-content.html is flaky and the new one in newmulticol/compare-with-old-impl/ will need the fixes for bug 113781 and bug 113058 in order to pass reliably. I'm not quite sure what this means. Did you intentionally make a test fail, and not even mark it accordingly in TestExpectations?
Comment 11 Morten Stenshorne 2014-04-23 10:26:03 PDT
This shouldn't have landed before the fix for bug 113058, but it did. Once that one has landed, the test will become stable.
Comment 12 Dave Hyatt 2014-04-23 11:02:17 PDT
This is my mistake. EWS was green so I just changed to cq+ without reading.
Comment 13 Dave Hyatt 2014-04-23 11:02:35 PDT
Anyway can land the other fix and then it will be fine.