Bug 131809

Summary:

[New Multicolumn] fast/multicol/overflow-content.html displays red

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Morten Stenshorne <mstensho>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, mstensho, thorton, webkit-bug-importer, WebkitBugTracker

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

131825

Attachments:

Description	Flags
Patch	none

Dave Hyatt

Reported 2014-04-17 13:39:22 PDT

Not clear if this is a test problem or if the new multi-column layout still has a bug. Will need to investigate the test to find out.

Attachments
Patch (14.68 KB, patch) 2014-04-22 17:39 PDT, Morten Stenshorne	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2014-04-17 21:33:02 PDT

Test is fine. Balancing is getting confused by overflow, so this is a legitimate bug.

Radar WebKit Bug Importer

Comment 2 2014-04-17 23:12:18 PDT

<rdar://problem/16656277>

Dave Hyatt

Comment 3 2014-04-21 13:44:14 PDT

This is a blocker for turning the new columns on.

Morten Stenshorne

Comment 4 2014-04-22 17:39:53 PDT

Created attachment 229931 [details] Patch

Morten Stenshorne

Comment 5 2014-04-22 17:42:13 PDT

overflow-content.html is flaky and the new one in newmulticol/compare-with-old-impl/ will need the fixes for bug 113781 and bug 113058 in order to pass reliably.

Dave Hyatt

Comment 6 2014-04-22 21:31:42 PDT

Comment on attachment 229931 [details] Patch r=me

WebKit Commit Bot

Comment 7 2014-04-23 06:36:58 PDT

Comment on attachment 229931 [details] Patch Clearing flags on attachment: 229931 Committed r167707: <http://trac.webkit.org/changeset/167707>

WebKit Commit Bot

Comment 8 2014-04-23 06:37:02 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 9 2014-04-23 10:17:11 PDT

This made fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html fail most of the time on several bots: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fmulticol%2Fnewmulticol%2Fcompare-with-old-impl%2Foverflow-content.html http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r167711%20(19379)/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-diffs.html

Alexey Proskuryakov

Comment 10 2014-04-23 10:20:32 PDT

(In reply to comment #5) > overflow-content.html is flaky and the new one in newmulticol/compare-with-old-impl/ will need the fixes for bug 113781 and bug 113058 in order to pass reliably. I'm not quite sure what this means. Did you intentionally make a test fail, and not even mark it accordingly in TestExpectations?

Morten Stenshorne

Comment 11 2014-04-23 10:26:03 PDT

This shouldn't have landed before the fix for bug 113058, but it did. Once that one has landed, the test will become stable.

Dave Hyatt

Comment 12 2014-04-23 11:02:17 PDT

This is my mistake. EWS was green so I just changed to cq+ without reading.

Dave Hyatt

Comment 13 2014-04-23 11:02:35 PDT

Anyway can land the other fix and then it will be fine.

Note You need to log in before you can comment on or make changes to this bug.