Bug 131795

Summary: [GTK] [Gardening] Update some test expectations for GTK
Product: WebKit Reporter: Eduardo Lima Mitev <elima>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eduardo Lima Mitev
Reported 2014-04-17 09:26:30 PDT
[GTK] [Gardening] Update some test expectations for GTK
Attachments
Patch (3.31 KB, patch)
2014-04-17 09:27 PDT, Eduardo Lima Mitev 		no flags
DetailsFormatted DiffDiff
Patch (3.29 KB, patch)
2014-04-17 11:09 PDT, Eduardo Lima Mitev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eduardo Lima Mitev
Comment 1 2014-04-17 09:27:10 PDT
Created attachment 229553 [details] Patch
WebKit Commit Bot
Comment 2 2014-04-17 10:26:43 PDT
Comment on attachment 229553 [details] Patch Rejecting attachment 229553 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 229553, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5244854577659904
Carlos Alberto Lopez Perez
Comment 3 2014-04-17 10:29:05 PDT
(In reply to comment #2) > (From update of attachment 229553 [details]) > Rejecting attachment 229553 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 229553, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit > > /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Full output: http://webkit-queues.appspot.com/results/5244854577659904 I think you forgot to add the "Unreviewed GTK gardening..." phrase to the changelog
Eduardo Lima Mitev
Comment 4 2014-04-17 11:09:07 PDT
Created attachment 229562 [details] Patch
Carlos Alberto Lopez Perez
Comment 5 2014-04-17 12:07:16 PDT
Seems this was already manually landed by mrobinson on http://trac.webkit.org/changeset/167438 I guess you can close this bug
Eduardo Lima Mitev
Comment 6 2014-04-17 12:13:13 PDT
Martin Robinson already committed the first patch. Thank you. Closing.
Note You need to log in before you can comment on or make changes to this bug.