Bug 131788

Summary: Remove CANVAS_PATH where possible
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Dirk Schulze 2014-04-16 23:26:16 PDT 
Since FF and Chrome ship an interoperable subset of Path2D it is time to remove CANVAS_PATH where possible.
Comment 1 Dirk Schulze 2014-04-16 23:43:47 PDT 
Created attachment 229525 [details]
Patch
Comment 2 Dirk Schulze 2014-04-17 06:51:56 PDT 
Created attachment 229540 [details]
Patch
Comment 3 Dean Jackson 2014-04-17 13:00:18 PDT 
Comment on attachment 229540 [details]
Patch

r+, but I don't really understand why you don't remove the flag entirely.
Comment 4 Dirk Schulze 2014-04-17 13:14:48 PDT 
(In reply to comment #3)
> (From update of attachment 229540 [details])
> r+, but I don't really understand why you don't remove the flag entirely.

Talked on IRC about that. The flag needs to stay because addPath is not ready for shipping yet. Browsers should disable CANVAS_PATH on shipping now.
Comment 5 WebKit Commit Bot 2014-04-17 13:32:46 PDT 
Comment on attachment 229540 [details]
Patch

Clearing flags on attachment: 229540

Committed r167451: <http://trac.webkit.org/changeset/167451>
Comment 6 WebKit Commit Bot 2014-04-17 13:32:51 PDT 
All reviewed patches have been landed.  Closing bug.