Bug 131781

Summary:

Uninline blend(Color, Color) to get AnimationUtilities out of Color.h

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Layout and Rendering

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+
patch	none

Description Tim Horton 2014-04-16 19:39:16 PDT

yep

Comment 1 Tim Horton 2014-04-16 19:39:58 PDT

Created attachment 229513 [details]
patch

Comment 2 WebKit Commit Bot 2014-04-16 19:42:18 PDT

Attachment 229513 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Color.cpp:470:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.cpp:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.cpp:472:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.cpp:478:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.cpp:479:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.cpp:480:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Simon Fraser (smfr) 2014-04-16 19:52:10 PDT

Comment on attachment 229513 [details]
patch

r=me if it builds.

Comment 4 Tim Horton 2014-04-16 19:52:40 PDT

Comment on attachment 229513 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229513&action=review

> Source/WebCore/ChangeLog:10
> +        These can be static now.

Or not, other platforms use them elsewhere.

Comment 5 Tim Horton 2014-04-16 19:58:44 PDT

Created attachment 229515 [details]
patch

Comment 6 WebKit Commit Bot 2014-04-17 00:33:51 PDT

Comment on attachment 229515 [details]
patch

Clearing flags on attachment: 229515

Committed r167423: <http://trac.webkit.org/changeset/167423>

Comment 7 WebKit Commit Bot 2014-04-17 00:33:54 PDT

All reviewed patches have been landed.  Closing bug.