Bug 131725

Summary: REGRESSION(r166779): [GTK] Printing doesn't work since r166779
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, pnormand, rakuco, sergio
Priority: P2 Keywords: Gtk, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Description Carlos Garcia Campos 2014-04-16 02:41:50 PDT
Printing doesn't work since r166779, but that revision was not the one introduced the problem, but just revealing it. The problem is that due to some typos in the makefiles, we are always building with printing disabled.

$ grep GTK_UNIX_PRINTING cmakeconfig.h 
#define HAVE_GTK_UNIX_PRINTING 0
Comment 1 Carlos Garcia Campos 2014-04-16 02:44:37 PDT
Created attachment 229435 [details]
Patch
Comment 2 Philippe Normand 2014-04-16 03:17:12 PDT
Comment on attachment 229435 [details]
Patch

Nice one Carlos :)
Comment 3 Carlos Garcia Campos 2014-04-16 03:20:33 PDT
Committed r167344: <http://trac.webkit.org/changeset/167344>