Bug 131725

Summary: REGRESSION(r166779): [GTK] Printing doesn't work since r166779
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, pnormand, rakuco, sergio
Priority: P2 Keywords: Gtk, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2014-04-16 02:41:50 PDT
Printing doesn't work since r166779, but that revision was not the one introduced the problem, but just revealing it. The problem is that due to some typos in the makefiles, we are always building with printing disabled. $ grep GTK_UNIX_PRINTING cmakeconfig.h #define HAVE_GTK_UNIX_PRINTING 0
Attachments
Patch (1.07 KB, patch)
2014-04-16 02:44 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-04-16 02:44:37 PDT
Created attachment 229435 [details] Patch
Philippe Normand
Comment 2 2014-04-16 03:17:12 PDT
Comment on attachment 229435 [details] Patch Nice one Carlos :)
Carlos Garcia Campos
Comment 3 2014-04-16 03:20:33 PDT
Committed r167344: <http://trac.webkit.org/changeset/167344>
Note You need to log in before you can comment on or make changes to this bug.