Bug 131721

Summary:

[GTK] Fix unused parameter warnings

Product:

WebKit

Reporter:

Brendan Long <b.long>

Component:

New Bugs

Assignee:

Brendan Long <b.long>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio, shiva.jm

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Brendan Long 2014-04-15 21:03:29 PDT

[GTK] Fix unused parameter warnings

Comment 1 Brendan Long 2014-04-15 21:05:25 PDT

Created attachment 229425 [details]
Patch

Comment 2 WebKit Commit Bot 2014-04-16 11:00:51 PDT

Comment on attachment 229425 [details]
Patch

Clearing flags on attachment: 229425

Committed r167360: <http://trac.webkit.org/changeset/167360>

Comment 3 WebKit Commit Bot 2014-04-16 11:00:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Alexey Proskuryakov 2014-04-16 12:55:06 PDT

This broke webkitpy regression tests. I'll fix.

[3/1417] webkit2.messages_unittest.ReceiverImplementationTest.test_receiver_implementation failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk1/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 337, in test_receiver_implementation
      self.assertGeneratedFileContentsEqual(file_contents, _expected_receiver_implementation)
    File "/Volumes/Data/slave/mavericks-release-tests-wk1/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 317, in assertGeneratedFileContentsEqual
      self.assertEquals(first_line, second_list[index])
  AssertionError: '    UNUSED_PARAM(decoder);' != '    ASSERT_NOT_REACHED();'

Comment 5 Alexey Proskuryakov 2014-04-16 13:03:45 PDT

Fixed in <http://trac.webkit.org/r167379>

Please do run test-webkitpy and test-webkitperl when changing scripts.

Comment 6 Shivakumar J M 2014-04-20 23:59:03 PDT

*** Bug 131730 has been marked as a duplicate of this bug. ***