Bug 131718

Summary: [Cocoa] Add a form delegate method corresponding to willSubmitForm
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Add -_webView:willSubmitFormValues:userObject:submissionHandler: thorton: review+

Description mitz 2014-04-15 17:53:23 PDT
[Cocoa] Add a form delegate method corresponding to willSubmitForm
Comment 1 mitz 2014-04-15 17:58:39 PDT
Created attachment 229422 [details]
Add -_webView:willSubmitFormValues:userObject:submissionHandler:
Comment 2 Joseph Pecoraro 2014-04-15 18:31:25 PDT
Comment on attachment 229422 [details]
Add -_webView:willSubmitFormValues:userObject:submissionHandler:

View in context: https://bugs.webkit.org/attachment.cgi?id=229422&action=review

Some drive-by nit comments.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1192
> +    class FormClient : public API::FormClient {

Can we make this final?

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:426
> +            userData = API::Data::createWithoutCopying((const unsigned char*)[data bytes], [data length], releaseNSData, data.leakRef()).leakRef();

Comment 3 mitz 2014-04-15 22:17:11 PDT
Committed <http://trac.webkit.org/r167343>.