Bug 131708

Summary: check-webkit-style doesn't check code style in .mm or .m files
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, darin, glenn, mitz, ossy, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
fix the test too darin: review+

Description Tim Horton 2014-04-15 15:11:52 PDT 
They're treated as plaintext, so we do check indentation and stuff, but do not apply code rules!

Additionally, the style checker isn't quite smart enough to handle ObjC yet, so we have to adjust some of the rules a bit.
Comment 1 Tim Horton 2014-04-15 15:12:29 PDT 
Most stuff already works because we frequently check style of ObjC headers.
Comment 2 Tim Horton 2014-04-15 15:40:17 PDT 
Created attachment 229410 [details]
patch

This covers all of the obvious false positives in a few ObjC(++) files I tested, but I'm sure there will be more, which we can fix as they come up.
Comment 3 Tim Horton 2014-04-15 15:43:02 PDT 
Created attachment 229411 [details]
fix the test too
Comment 4 Tim Horton 2014-04-16 10:18:49 PDT 
http://trac.webkit.org/changeset/167350