Bug 131708

Summary: check-webkit-style doesn't check code style in .mm or .m files
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, darin, glenn, mitz, ossy, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
fix the test too darin: review+

Tim Horton
Reported 2014-04-15 15:11:52 PDT
They're treated as plaintext, so we do check indentation and stuff, but do not apply code rules! Additionally, the style checker isn't quite smart enough to handle ObjC yet, so we have to adjust some of the rules a bit.
Attachments
patch (6.18 KB, patch)
2014-04-15 15:40 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
fix the test too (7.05 KB, patch)
2014-04-15 15:43 PDT, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-04-15 15:12:29 PDT
Most stuff already works because we frequently check style of ObjC headers.
Tim Horton
Comment 2 2014-04-15 15:40:17 PDT
Created attachment 229410 [details] patch This covers all of the obvious false positives in a few ObjC(++) files I tested, but I'm sure there will be more, which we can fix as they come up.
Tim Horton
Comment 3 2014-04-15 15:43:02 PDT
Created attachment 229411 [details] fix the test too
Tim Horton
Comment 4 2014-04-16 10:18:49 PDT
http://trac.webkit.org/changeset/167350
Note You need to log in before you can comment on or make changes to this bug.