Bug 131706

Summary: PDFPlugin style fixes
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Tim Horton
Reported 2014-04-15 15:07:33 PDT
While working on getting the style checker to check Objective-C source files, I ran through all of the errors in PDFPlugin.mm and fixed the ones that were broken in the style-checker there, and the ones that were broken in PDFPlugin here. No reason to throw away good style fixes, so let's land them.
Attachments
patch (12.65 KB, patch)
2014-04-15 15:08 PDT, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-04-15 15:08:39 PDT
Created attachment 229407 [details] patch
WebKit Commit Bot
Comment 2 2014-04-15 15:10:41 PDT
Attachment 229407 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-04-16 10:56:01 PDT
http://trac.webkit.org/changeset/167357
Note You need to log in before you can comment on or make changes to this bug.