Bug 131690

Summary:

MacroAssemblerX86::moveDoubleToInts() shouldn't clobber the source

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, jbriance, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Do not clobber src register in MacroAssemblerX86::moveDoubleToInts()	oliver: review+

Filip Pizlo

Reported 2014-04-15 12:34:20 PDT

...

Attachments
Do not clobber src register in MacroAssemblerX86::moveDoubleToInts() (3.67 KB, patch) 2014-09-12 14:00 PDT, Julien Brianceau	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2014-09-12 14:00:06 PDT

Created attachment 238053 [details] Do not clobber src register in MacroAssemblerX86::moveDoubleToInts()

Oliver Hunt

Comment 2 2014-09-12 14:56:36 PDT

Comment on attachment 238053 [details] Do not clobber src register in MacroAssemblerX86::moveDoubleToInts() r=me assuming perf is good

Julien Brianceau

Comment 3 2014-09-12 15:03:44 PDT

Note You need to log in before you can comment on or make changes to this bug.