Bug 131690 - MacroAssemblerX86::moveDoubleToInts() shouldn't clobber the source
Summary: MacroAssemblerX86::moveDoubleToInts() shouldn't clobber the source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 12:34 PDT by Filip Pizlo
Modified: 2014-09-12 15:03 PDT (History)
8 users (show)

See Also:


Attachments
Do not clobber src register in MacroAssemblerX86::moveDoubleToInts() (3.67 KB, patch)
2014-09-12 14:00 PDT, Julien Brianceau
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-04-15 12:34:20 PDT
...
Comment 1 Julien Brianceau 2014-09-12 14:00:06 PDT
Created attachment 238053 [details]
Do not clobber src register in MacroAssemblerX86::moveDoubleToInts()
Comment 2 Oliver Hunt 2014-09-12 14:56:36 PDT
Comment on attachment 238053 [details]
Do not clobber src register in MacroAssemblerX86::moveDoubleToInts()

r=me assuming perf is good
Comment 3 Julien Brianceau 2014-09-12 15:03:44 PDT
Manually committed r173580: http://trac.webkit.org/changeset/173580