Bug 131689
| Summary: | Turn NodeResultMask in NodeFlags into something that more directly conveys the representation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> |
| Status: | NEW | ||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 131423 | ||
| Bug Blocks: | |||
Filip Pizlo
Both UseKind and NodeResultMask may convey representation. The possible representations are Value, Double, and Int52. We should really have a separate enum for Representation. NodeResultMask could still internally use the same format as it does now. Then we could also have the notion of "guaranteeing" that a node returns an Int32, Number, or Boolean - but we should encapsulate this somehow and separate it from NodeResultMask. That would allow us to get rid of horrible things like canonicalResultRepresentation().
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |