Bug 131674

Summary:

Web Inspector: CodeMirror LICENSE is not properly added to combined files

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2014-04-15 01:49:39 PDT

The combined CodeMirror.js and CodeMirror.css files contain the WebKit license header not the CodeMirror license.

Comment 1 Radar WebKit Bug Importer 2014-04-15 01:50:44 PDT

<rdar://problem/16618318>

Comment 2 Timothy Hatcher 2014-04-15 01:53:43 PDT

Created attachment 229363 [details]
Patch

Comment 3 WebKit Commit Bot 2014-04-15 09:16:54 PDT

Comment on attachment 229363 [details]
Patch

Clearing flags on attachment: 229363

Committed r167307: <http://trac.webkit.org/changeset/167307>

Comment 4 WebKit Commit Bot 2014-04-15 09:16:57 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Joseph Pecoraro 2014-04-15 18:52:03 PDT

Doh! Good catch