Bug 131674 - Web Inspector: CodeMirror LICENSE is not properly added to combined files
Summary: Web Inspector: CodeMirror LICENSE is not properly added to combined files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-15 01:49 PDT by Timothy Hatcher
Modified: 2014-04-15 18:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2014-04-15 01:53 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-04-15 01:49:39 PDT
The combined CodeMirror.js and CodeMirror.css files contain the WebKit license header not the CodeMirror license.
Comment 1 Radar WebKit Bug Importer 2014-04-15 01:50:44 PDT
<rdar://problem/16618318>
Comment 2 Timothy Hatcher 2014-04-15 01:53:43 PDT
Created attachment 229363 [details]
Patch
Comment 3 WebKit Commit Bot 2014-04-15 09:16:54 PDT
Comment on attachment 229363 [details]
Patch

Clearing flags on attachment: 229363

Committed r167307: <http://trac.webkit.org/changeset/167307>
Comment 4 WebKit Commit Bot 2014-04-15 09:16:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2014-04-15 18:52:03 PDT
Doh! Good catch