Bug 131638

Summary: [iOS][WK2] Change the SPI used when starting the rotation animation
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2014-04-14 15:15:07 PDT
[iOS][WK2] Change the SPI used when starting the rotation animation
Attachments
Patch (7.99 KB, patch)
2014-04-14 15:15 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (8.02 KB, patch)
2014-04-14 15:28 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-04-14 15:15:34 PDT
Created attachment 229309 [details] Patch
Ian Henderson
Comment 2 2014-04-14 15:18:17 PDT
Comment on attachment 229309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229309&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:111 > +- (void)_beginAnimatedResize:(void (^)(void))updateBlock; I think the argument should be called out somehow in the selector name. E.g. - (void)_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock; Everything looks good to me otherwise!
Benjamin Poulain
Comment 3 2014-04-14 15:28:53 PDT
Created attachment 229311 [details] Patch
Benjamin Poulain
Comment 4 2014-04-14 15:39:40 PDT
Comment on attachment 229311 [details] Patch Clearing flags on attachment: 229311 Committed r167274: <http://trac.webkit.org/changeset/167274>
Benjamin Poulain
Comment 5 2014-04-14 15:39:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.