| Summary: | [iOS][WK2] Change the SPI used when starting the rotation animation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2014-04-14 15:15:07 PDT
Created attachment 229309 [details]
Patch
Comment on attachment 229309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229309&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:111 > +- (void)_beginAnimatedResize:(void (^)(void))updateBlock; I think the argument should be called out somehow in the selector name. E.g. - (void)_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock; Everything looks good to me otherwise! Created attachment 229311 [details]
Patch
Comment on attachment 229311 [details] Patch Clearing flags on attachment: 229311 Committed r167274: <http://trac.webkit.org/changeset/167274> All reviewed patches have been landed. Closing bug. |